-
Notifications
You must be signed in to change notification settings - Fork 29
Added Schnorr Signature & EC256 libraries #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dovgopoly
commented
Apr 25, 2025
- Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
- Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
- This PR is just a minor change, like a typo fix.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 45 47 +2
Lines 3246 3313 +67
Branches 390 391 +1
=======================================
+ Hits 3244 3311 +67
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Arvolear
reviewed
Apr 25, 2025
Arvolear
reviewed
Apr 25, 2025
Arvolear
reviewed
May 1, 2025
Arvolear
reviewed
May 1, 2025
Arvolear
reviewed
May 1, 2025
Arvolear
reviewed
May 1, 2025
Arvolear
reviewed
May 1, 2025
Arvolear
reviewed
May 1, 2025
Arvolear
reviewed
May 1, 2025
Arvolear
reviewed
May 1, 2025
Arvolear
reviewed
May 1, 2025
Please check the coverage and update the README. |
Arvolear
approved these changes
May 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.